Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows icon #6

Merged
merged 2 commits into from Jan 12, 2021
Merged

Update windows icon #6

merged 2 commits into from Jan 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2021

@BigslimVdub , it looks like this fixes the icon issues and my build issues.

I updated to node-sass 4.13.0 and it is building correctly now.

Here are the errors for 4.12.0

C:\Users\user111\Downloads\AeonLW-master>npm install

> [email protected] install C:\Users\user111\Downloads\AeonLW-master\node_modules\node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.12.0/win32-x64-83_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.12.0/win32-x64-83_binding.node":

HTTP error 404 Not Found

Hint: If github.com is not accessible in your location
      try setting a proxy via HTTP_PROXY, e.g.

      export HTTP_PROXY=http://example.com:1234

or configure npm proxy via

      npm config set proxy http://example.com:8080

> [email protected] postinstall C:\Users\user111\Downloads\AeonLW-master\node_modules\node-sass
> node scripts/build.js

Building: C:\Program Files\nodejs\node.exe C:\Users\user111\Downloads\AeonLW-master\node_modules\node-gyp\bin\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli   'C:\\Program Files\\nodejs\\node.exe',
gyp verb cli   'C:\\Users\\user111\\Downloads\\AeonLW-master\\node_modules\\node-gyp\\bin\\node-gyp.js',
gyp verb cli   'rebuild',
gyp verb cli   '--verbose',
gyp verb cli   '--libsass_ext=',
gyp verb cli   '--libsass_cflags=',
gyp verb cli   '--libsass_ldflags=',
gyp verb cli   '--libsass_library='
gyp verb cli ]
gyp info using [email protected]
gyp info using [email protected] | win32 | x64
gyp verb command rebuild []
gyp verb command clean []
gyp verb clean removing "build" directory
gyp verb command configure []
gyp verb check python checking for Python executable "python2" in the PATH
gyp verb `which` failed Error: not found: python2
gyp verb `which` failed     at getNotFoundError (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:13:12)
gyp verb `which` failed     at F (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:68:19)
gyp verb `which` failed     at E (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:80:29)
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:89:16
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\isexe\index.js:42:5
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\isexe\windows.js:36:5
gyp verb `which` failed     at FSReqCallback.oncomplete (fs.js:183:21)
gyp verb `which` failed  python2 Error: not found: python2
gyp verb `which` failed     at getNotFoundError (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:13:12)
gyp verb `which` failed     at F (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:68:19)
gyp verb `which` failed     at E (C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:80:29)
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\which\which.js:89:16
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\isexe\index.js:42:5
gyp verb `which` failed     at C:\Users\user111\Downloads\AeonLW-master\node_modules\isexe\windows.js:36:5
gyp verb `which` failed     at FSReqCallback.oncomplete (fs.js:183:21) {
gyp verb `which` failed   code: 'ENOENT'
gyp verb `which` failed }
gyp verb check python checking for Python executable "python" in the PATH
gyp verb `which` succeeded python C:\Users\user111\AppData\Local\Programs\Python\Python39\python.EXE
gyp ERR! configure error
gyp ERR! stack Error: Command failed: C:\Users\user111\AppData\Local\Programs\Python\Python39\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack   File "<string>", line 1
gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack                       ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:308:12)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at maybeClose (internal/child_process.js:1048:16)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:288:5)
gyp ERR! System Windows_NT 10.0.19041
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\user111\\Downloads\\AeonLW-master\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd C:\Users\user111\Downloads\AeonLW-master\node_modules\node-sass
gyp ERR! node -v v14.15.4
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Build failed with error code: 1
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\user111\AppData\Roaming\npm-cache\_logs\2021-01-10T19_53_09_355Z-debug.log

@ghost
Copy link
Author

ghost commented Jan 10, 2021

sass/node-sass#2770

@ghost ghost mentioned this pull request Jan 11, 2021
@BigslimVdub BigslimVdub added enhancement New feature or request good first issue Good for newcomers labels Jan 12, 2021
@BigslimVdub BigslimVdub linked an issue Jan 12, 2021 that may be closed by this pull request
@BigslimVdub
Copy link
Owner

Pretty sure I actually accidentally deleted this last year before the release for some reason

@BigslimVdub BigslimVdub merged commit dda9870 into BigslimVdub:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jagged icon issue
1 participant