Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove company property #95

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Remove company property #95

merged 1 commit into from
Aug 10, 2024

Conversation

Bilbottom
Copy link
Owner

@Bilbottom Bilbottom commented Aug 10, 2024

Summary by Sourcery

Remove the 'company' property from test files, schemas, and SQL models to streamline data models and update the pre-commit configuration to exclude all files from SQL linting temporarily.

Enhancements:

  • Remove the 'company' property from various test files and schemas to simplify data models.

Build:

  • Update pre-commit configuration to exclude all files from SQL linting temporarily.

Copy link

sourcery-ai bot commented Aug 10, 2024

Reviewer's Guide by Sourcery

This pull request removes the 'company' property from various test files, schema definitions, and SQL select statements. The changes ensure that the 'company' field is no longer part of the data model, reflecting a shift in how company information is managed. Additionally, the pre-commit configuration has been updated to exclude all files from sqlfluff-lint temporarily.

File-Level Changes

Files Changes
billiam_database/models/presentation/tests/test__pl__daily_tracker.yml
billiam_database/models/staging/tests/test__stg__daily_tracker.yml
billiam_database/models/presentation/tests/test__pl__daily_metrics.yml
billiam_database/models/presentation/tests/test__pl__task_details.yml
Removed 'company' property from input and expect rows in various test files.
billiam_database/models/presentation/_schema.yml
billiam_database/models/staging/_schema.yml
Removed 'company' field definition and constraints from schema files.
billiam_database/models/presentation/pl__daily_tracker.sql
billiam_database/models/staging/stg__daily_tracker.sql
Removed 'company' column from final select statements in SQL files.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Bilbottom - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide some context on why the 'company' property is being removed? Understanding the rationale behind this change would be helpful, especially considering its impact across multiple parts of the data model.
  • We noticed that SQL linting has been excluded in the .pre-commit-config.yaml file. Is this a temporary measure? If so, it would be good to have a plan or timeline for re-enabling it in the future.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Bilbottom Bilbottom merged commit 8180da2 into main Aug 10, 2024
2 checks passed
@Bilbottom Bilbottom deleted the schema-changes branch August 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant