Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from dbt to SQLMesh #97

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Switch from dbt to SQLMesh #97

merged 1 commit into from
Dec 21, 2024

Conversation

Bilbottom
Copy link
Owner

@Bilbottom Bilbottom commented Dec 21, 2024

Summary by Sourcery

Migrate from dbt to SQLMesh.

Build:

  • Remove dbt from the project dependencies and configuration.
  • Add SQLMesh to the project dependencies and configuration.
  • Update the pre-commit hooks to use SQLMesh instead of dbt.

CI:

  • Update the CI workflow to use SQLMesh instead of dbt.

Documentation:

  • Update the README to reflect the switch to SQLMesh.

Tests:

  • Update the unit tests to use SQLMesh instead of dbt.

This comment was marked as resolved.

@Bilbottom Bilbottom requested a review from Copilot December 21, 2024 11:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 64 out of 79 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .github/workflows/deploy-dbt.yaml: Language not supported
  • billiam_database/dbt_project.yml: Language not supported
  • billiam_database/gsheets.sql: Language not supported
  • billiam_database/macros/_macros.yml: Language not supported
  • billiam_database/macros/ci/_macros.yml: Language not supported
  • billiam_database/macros/ci/set_ci_environment.sql: Language not supported
  • billiam_database/macros/configs/generate_schema_name.sql: Language not supported
  • billiam_database/macros/import.sql: Language not supported
  • billiam_database/macros/udfs/_macros.yml: Language not supported
  • billiam_database/macros/udfs/create_udfs.sql: Language not supported
  • billiam_database/macros/udfs/within.sql: Language not supported
  • billiam_database/models/groups.yml: Language not supported
  • billiam_database/models/_docs.md: Evaluated as low risk
  • billiam_database/models/intermediate/_docs.md: Evaluated as low risk
  • billiam_database/macros/within.py: Evaluated as low risk
Comments suppressed due to low confidence (3)

README.md:76

  • [nitpick] The phrase 'The SQLMesh UI is great for doing these with a GUI' could be more precise. Consider rephrasing to 'The SQLMesh UI provides a graphical interface for these operations.'
sqlmesh -p billiam_database ui

README.md:83

  • [nitpick] The warning 'might not work in all circumstances' is vague. Consider specifying potential issues like 'The DuckDB driver for Metabase is a community driver and may have compatibility issues with certain versions or features.'
> The DuckDB driver for Metabase is a community driver. This means that it might not work in all circumstances.

.github/workflows/tests.yaml:7

  • Confirm if the pull request trigger was intentionally commented out.
#  - pull_request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Bilbottom - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding SQLMesh CI steps to replace the removed dbt pipeline steps to maintain CI coverage
  • Please add context in the PR description about the rationale for migrating from dbt to SQLMesh to help reviewers understand the motivation for this change
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

billiam_database/models/raw/finances.sql Show resolved Hide resolved
billiam_database/tests/macros/test__within.py Show resolved Hide resolved
@Bilbottom Bilbottom merged commit 97d1daa into main Dec 21, 2024
1 of 2 checks passed
@Bilbottom Bilbottom deleted the switch-to-sqlmesh branch December 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant