-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview of Page Templates #12
Comments
Thanks - that's a good idea and I really appreciate the feedback! On a slightly related note - what do you think of page templates now that we have Gutenberg? Are they still needed if you can add custom features to any page anyway? I am wondering about removing some/ all of the page templates as I think their use is less relevant now. But then I am not everyone so I wonder if other people would still find them useful. What do you think? Thanks |
Hey Ben Page templates are needed. For now anyway and likely another 6 or so months until Gutenberg has a way to save templates (kinda like saving reusable blocks). In the mean time it would be good to add page templates in the existing fashion so to speak. If you can write a bit about the page templates you have made then I can also figure out how to test them out and give you feedback directly on those. |
Add descriptions of all templates to readme.txt Remove guestbook template since it's use is limited (you could use a normal page for the same effect). Add content only template so we can build totally custom pages with the new editor #12
Thanks - that makes sense. I've updated the readme.txt to include descriptions of the templates, and made a couple of template based changes. Keep in mind that I haven't tested these templates yet. They probably don't work 100% - I'm still focused on getting the theme design to look right. I'll go through and fix stuff once the theme looks nice :) |
Hey @paaljoachim are the changes I made ok or would you like to see something else? |
Hey Ben..:) Going through the page templates. Contributors. Shows the background color selected through the customizer. Child Page Grid. Kinda shows sub pages like a blog page shows blog posts. Portfolio. Not checked. I would just leave all of them in as they are (for now anyway). |
Hey
I took a look at the Page Attributes -> Templates and noticed a few.
It would be great if you could add some notes to the readme about each template. Name and what they do. As it would be easier to get an overview of what the theme contains.
Thanks.
The text was updated successfully, but these errors were encountered: