Merge pull request apache#35 from rafael-telles/to-string-array-jdbc-…

…review Implement toString method for JdbcArray class
Bit-Quill · Apr 22, 2022 · e2fee64 · e2fee64
2 parents f24ef45 + c1e0cc3
commit e2fee64
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/...t/flight-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArray.java b/...t/flight-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArray.java
@@ -21,6 +21,7 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.SQLFeatureNotSupportedException;
+import java.util.Arrays;
 import java.util.Map;
 
 import org.apache.arrow.driver.jdbc.accessor.impl.complex.AbstractArrowFlightJdbcListVectorAccessor;
@@ -30,6 +31,7 @@
 import org.apache.arrow.vector.ValueVector;
 import org.apache.arrow.vector.VectorSchemaRoot;
 import org.apache.arrow.vector.types.pojo.ArrowType;
+import org.apache.arrow.vector.util.JsonStringArrayList;
 import org.apache.arrow.vector.util.TransferPair;
 
 /**
@@ -160,4 +162,17 @@ public ResultSet getResultSet(long index, int count, Map<String, Class<?>> map)
   public void free() {
 
   }
+
+  @Override
+  public String toString() {
+    JsonStringArrayList<Object> array = new JsonStringArrayList<>((int) this.valuesCount);
+
+    try {
+      array.addAll(Arrays.asList((Object[]) getArray()));
+    } catch (SQLException e) {
+      throw new RuntimeException(e);
+    }
+
+    return array.toString();
+  }
 }
diff --git a/...ight-jdbc-driver/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArrayTest.java b/...ight-jdbc-driver/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArrayTest.java
@@ -21,10 +21,12 @@
 import java.sql.SQLException;
 import java.sql.SQLFeatureNotSupportedException;
 import java.sql.Types;
+import java.util.Arrays;
 import java.util.HashMap;
 
 import org.apache.arrow.driver.jdbc.utils.RootAllocatorTestRule;
 import org.apache.arrow.vector.IntVector;
+import org.apache.arrow.vector.util.JsonStringArrayList;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
@@ -142,6 +144,17 @@ public void testShouldGetResultSetReturnValidResultSetWithOffsets() throws SQLEx
     }
   }
 
+  @Test
+  public void testToString() throws SQLException {
+    ArrowFlightJdbcArray arrowFlightJdbcArray =
+        new ArrowFlightJdbcArray(dataVector, 0, dataVector.getValueCount());
+
+    JsonStringArrayList<Object> array = new JsonStringArrayList<>();
+    array.addAll(Arrays.asList((Object[]) arrowFlightJdbcArray.getArray()));
+
+    Assert.assertEquals(array.toString(), arrowFlightJdbcArray.toString());
+  }
+
   @Test(expected = SQLFeatureNotSupportedException.class)
   public void testShouldGetResultSetWithMapNotBeSupported() throws SQLException {
     ArrowFlightJdbcArray arrowFlightJdbcArray =