Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Day Of Year Function To OpenSearch #172

Conversation

GabeFernandez310
Copy link

Description

Adds the day_of_year function to the SQL plugin. It behaves like the dayofyear function which already exists in the new engine, and both are aligned with MySQL

Issues Resolved

opensearch-project#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #172 (7bfd8d9) into integ-add-legacy-syntax-for-matchphrase-function (e280866) will decrease coverage by 2.52%.
The diff coverage is 100.00%.

@@                                  Coverage Diff                                   @@
##             integ-add-legacy-syntax-for-matchphrase-function     #172      +/-   ##
======================================================================================
- Coverage                                               98.28%   95.75%   -2.53%     
  Complexity                                               3450     3450              
======================================================================================
  Files                                                     345      355      +10     
  Lines                                                    8580     9240     +660     
  Branches                                                  547      666     +119     
======================================================================================
+ Hits                                                     8433     8848     +415     
- Misses                                                    142      334     +192     
- Partials                                                    5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/storage/script/filter/FilterQueryBuilder.java 100.00% <ø> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <100.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acarbonetto
Copy link

I think you might have used the two dev/integration branches for this PR.

integ-add-legacy-syntax-for-matchphrase-function from dev-add-legacy-syntax-for-matchphrase-function-alternate

@GabeFernandez310 GabeFernandez310 deleted the dev-add-legacy-syntax-for-matchphrase-function-alternate branch December 1, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants