Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop prometheus in doctest build.gradle now runs upon project failure in startOpenSearch #276

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

MitchellGale
Copy link

@MitchellGale MitchellGale commented Jun 15, 2023

startOpenSearch is now finalizedBy stopPrometheus allowing stop prometheus to run after crash. This stops a left-over prometheus instance from running after causing future start Prometheus tasks from running.

Steps to reproduce error that is fixed.

  1. Run an OpenSearch instance
  2. Run build in OpenSearch SQL
  3. Observe that OpenSearch SQL crashes due to step 1
  4. Stop OpenSearch instance started in step 1
  5. Re-run build for OpenSearch SQL
  6. Observe that there is error about Prometheus already running.

Same steps can be taken working from this PR branch and it will not show the error in step 6.

Issues Resolved

1083

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (Integ/FixPrometheus@2c80631). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6f2e2da differs from pull request most recent head 7de928c. Consider uploading reports for the commit 7de928c to get more accurate results

@@                  Coverage Diff                   @@
##             Integ/FixPrometheus     #276   +/-   ##
======================================================
  Coverage                       ?   97.41%           
  Complexity                     ?     4558           
======================================================
  Files                          ?      388           
  Lines                          ?    11238           
  Branches                       ?      790           
======================================================
  Hits                           ?    10947           
  Misses                         ?      284           
  Partials                       ?        7           
Flag Coverage Δ
sql-engine 97.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MitchellGale MitchellGale merged commit 07f6a8a into Integ/FixPrometheus Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants