Fix certificate validation for ODBC driver #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#696 and 317 all together. Signed-off-by: Yury Fridlyand <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main opensearch-project/sql#34 +/- ##
=========================================
Coverage 99.92% 99.92%
Complexity 2698 2698
=========================================
Files 257 257
Lines 6491 6491
Branches 402 402
=========================================
Hits 6486 6486
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
alexmeizer
approved these changes
Mar 3, 2022
Yury-Fridlyand
requested review from
a user,
jduo,
kylepbit,
MaxKsyunz and
raymond-lum
ghost
approved these changes
Mar 3, 2022
jduo
reviewed
Mar 3, 2022
| cmd.exe /c bootstrap-vcpkg.bat | ||
| .\vcpkg.exe integrate install | ||
| .\vcpkg.exe install curl[tool]:${LIBCURL_WIN_ARCH}-windows | ||
| } |
There was a problem hiding this comment.
Nit: please add a newline to the end of any files.
jduo
approved these changes
Mar 3, 2022
MaxKsyunz
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hostname Verificationparameter, and once it unset driver can establish SSL connection even if self-signed certificates are usedThis PR has all changes from PRs opensearch-project#28, opensearch-project#29 and opensearch-project#30 collected all together.
Duplicate of opensearch-project#32, but with fix of DCO.
Issues Resolved
opendistro-for-elasticsearch/sql#686
opendistro-for-elasticsearch/sql#783
opensearch-project/sql-odbc#15
opensearch-project/sql-odbc#8
Applicable for ODFE too
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.