Merge pull request #50 from BitBagCommerce/hotfix/OP-131

OP-131/Fix composer dependency
BitBagCommerce · Apr 7, 2023 · 3e64c9a · 3e64c9a
2 parents 31ef194 + b1e0f66
commit 3e64c9a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -23,7 +23,7 @@ jobs:
                 php: [ 8.0 ]
                 symfony: [ ^5.4, ^6.0 ]
                 sylius: [ ~1.11.0, ~1.12.0 ]
-                node: [ 12.x ]
+                node: [ 14.x ]
                 mysql: [ 5.7, 8.0 ]
 
                 exclude:

diff --git a/.github/workflows/coding_standard.yml b/.github/workflows/coding_standard.yml
@@ -15,15 +15,15 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php: ["7.4", "8.0"]
-                symfony: ["^5.2"]
-                sylius: ["~1.10.0", "~1.11.0"]
-                node: ["10.x"]
-                mysql: ["8.0"]
+                php: [ 8.0]
+                symfony: [^5.4, ^6.0]
+                sylius: [~1.11.0, ~1.12.0]
+                node: [14.x]
+                mysql: [8.0]
 
                 exclude:
                     -   sylius: ~1.11.0
-                        php: 7.4
+                        symfony: ^6.0
 
         env:
             APP_ENV: test

diff --git a/composer.json b/composer.json
@@ -9,8 +9,8 @@
     ],
     "license": "MIT",
     "require": {
-        "php": "^7.4 || ^8.0",
-        "sylius/sylius": "^1.10"
+        "php": "^8.0",
+        "sylius/sylius": "^1.11 || ^1.12"
     },
     "require-dev": {
         "behat/behat": "^3.6.1",

diff --git a/src/Validator/AdValidator.php b/src/Validator/AdValidator.php
@@ -19,7 +19,7 @@
 
 final class AdValidator extends ConstraintValidator
 {
-    public function validate($ad, Constraint $constraint): void
+    public function validate(mixed $ad, Constraint $constraint): void
     {
         Assert::isInstanceOf($ad, AdInterface::class);
 

diff --git a/src/Validator/BannerValidator.php b/src/Validator/BannerValidator.php
@@ -19,7 +19,7 @@
 
 final class BannerValidator extends ConstraintValidator
 {
-    public function validate($banner, Constraint $constraint): void
+    public function validate(mixed $banner, Constraint $constraint): void
     {
         Assert::isInstanceOf($banner, BannerInterface::class);