add value field #29
Closed
add value field #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hey @drefixs , I like the idea! Can you rebase your commit on master, so we won't see the diff from the memory leaks fix here ? Thanks a lot ! |
BitOne
requested changes
Nov 7, 2016
| @@ -448,12 +454,22 @@ void meminfo_zval_dump(php_stream * stream, char * frame_label, char * symbol_na | |||
| php_stream_printf(stream TSRMLS_CC, " \"type\" : \"%s\",\n", zend_get_type_by_const(Z_TYPE_P(zv))); | |||
| php_stream_printf(stream TSRMLS_CC, " \"size\" : \"%ld\",\n", meminfo_get_element_size(zv)); | |||
|
|
|||
| php_json_encode(&buf, zv, (int)0); | |||
There was a problem hiding this comment.
I'm afraid this only works if the JSON extension is loaded, which is not guaranteed.
|
@drefixs : Could you please provide an option or parameter so users that want to display value can provide this parameter. I'm afraid that displaying value by default will make the file far less easier to read. |
BitOne
force-pushed
the
master
branch
25 times, most recently
from
5e00cf6 to
4d0010a
Compare
BitOne
force-pushed
the
master
branch
7 times, most recently
from
9a97514 to
0e4f884
Compare
|
Closed because the code changed too much since this PR was opened. But I keep the idea from #31 opened and will implemented latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.