-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]窗口化缩放 #1071
Open
Blinue
wants to merge
18
commits into
dev
Choose a base branch
from
windowed-mode
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP]窗口化缩放 #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
已知和 Windows Terminal 不兼容
切换前台窗口不会退出缩放。已知和某些透明窗口不兼容,如果该窗口存在且显卡不支持 MPO,DirectFlip 无法生效,使得延迟大增
增加调试信息
Blinue
commented
Feb 14, 2025
@@ -210,28 +242,142 @@ ScalingError ScalingWindow::Create( | |||
}; | |||
RegisterClassEx(&wcex); | |||
|
|||
wcex.lpfnWndProc = DefWindowProc; | |||
wcex.lpszClassName = CommonSharedConstants::SWAP_CHAIN_CHILD_WINDOW_CLASS_NAME; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文档说 HINSTANCE 是包含窗口过程的模块句柄,而 DefWindowProc 是系统 dll 中的函数,所以这里确实有问题。我倾向于改成 lambda 函数,这样可以继续使用 exe 的句柄。
wcex.lpfnWndProc = [](HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam) {
return DefWindowProc(hWnd, msg, wParam, lParam);
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #135
这个 PR 用于跟踪开发进度和收集反馈。预期需要很多探索来决定路线,可能需要针对不同类型的窗口做不同的适配。已实现的功能: