use stat instead of lstat on files and directories #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstat does not follow symlinks, so if you have a directory symlinked, my_existsdir tells us, it does not exists. use S_ISREG (== file) instead of !S_ISDIR (==not directory) on regular files. There are more inode-types than files and directories.
|
Good find, thanks! |
midwan
pushed a commit
that referenced
this pull request
May 4, 2024
lstat does not follow symlinks, so if you have a directory symlinked, my_existsdir tells us, it does not exists. use S_ISREG (== file) instead of !S_ISDIR (==not directory) on regular files. There are more inode-types than files and directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lstat does not follow symlinks, so if you have a directory symlinked, my_existsdir tells us, it does not exists.
use S_ISREG (== file) instead of !S_ISDIR (==not directory) on regular files. There are more inode-types than files and directories.
Fixes # .
Changes proposed in this pull request:
@midwan