Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nettlesome Phosphor Name #1456

Closed
YoungGT opened this issue May 16, 2018 · 2 comments
Closed

Nettlesome Phosphor Name #1456

YoungGT opened this issue May 16, 2018 · 2 comments

Comments

@YoungGT
Copy link
Contributor

YoungGT commented May 16, 2018

There‘re four materials that contain phosphorus : phosphorus ,phosphor ,phosphate and phosphorous pentoxide. The last one is very identifiable ,but those three items are very indecipherable in GT. But why? The reason is that the names of them in GT are confused. Let us check them out.
I list them up
And we can find that the names of phosphorus and phosphor wrong easily.
I'm trying to translate the language file into Chinese and it really makes me vexed. So I'd like to correct the primary names by the containing elements.

Dream-Master referenced this issue in GTNewHorizons/GT5-Unofficial Dec 11, 2018
Fix #1439 and #1456 (#1503)

* Fix #1439

* Fix #1456

* mistake
@draknyte1
Copy link
Collaborator

As Dream has found, this breaks mods using these materials. The old ones should be deprecated, not removed. Look at other examples within the materials clas.

@draknyte1 draknyte1 reopened this Dec 11, 2018
@draknyte1
Copy link
Collaborator

@Blood-Asp I would’ve noticed this upon review, your reckless merging is a pain in the ass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants