Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1439 and #1456 #1503

Merged
merged 5 commits into from
Dec 9, 2018
Merged

Fix #1439 and #1456 #1503

merged 5 commits into from
Dec 9, 2018

Conversation

YoungGT
Copy link
Contributor

@YoungGT YoungGT commented Dec 9, 2018

Change nuggets of the primitive blast furnace recipe to 6 and EBF to 9, should fix #1439.
And correct phosphorus's name according to #1456. But I just change Chinese and English language files, I can't speak Russian and German, hope somebody help me.

@YoungGT YoungGT changed the title Fix #1439 Fix #1439 and #1456 Dec 9, 2018
@Blood-Asp
Copy link
Owner

Looks mostly fine besides the one removed recipe.

Changing material names will break minetweaker recipes but should not be that bad. As materials are saved as IDs and not by their names renaming them should not remove them form the saves like it happens with fluids.

No idea if the oredict entrys are used by other mods. can't remember any that do.

@YoungGT
Copy link
Contributor Author

YoungGT commented Dec 9, 2018

Well that recipe should be a mistake, but as for mt, don't know and can't fix thought....

@Blood-Asp Blood-Asp merged commit cd841ad into Blood-Asp:unstable Dec 9, 2018
Dream-Master referenced this pull request in GTNewHorizons/GT5-Unofficial Dec 11, 2018
Fix #1439 and #1456 (#1503)

* Fix #1439

* Fix #1456

* mistake
@draknyte1
Copy link
Collaborator

#1456 (comment)

Because you’re a useless dev, what about explicit calls to those materials? That will break.

@Blood-Asp
Copy link
Owner

And how about you shut up. If everything you write is an insult it is not needed whatevery quality on the coding side.

@draknyte1
Copy link
Collaborator

draknyte1 commented Dec 12, 2018

f866e385-9c36-4689-a80d-d94a1e43427e
But I wasn’t wrong though. 🤔

And how about you shut up. If everything you write is an insult it is not needed whatevery quality on the coding side.

Didn't actually respond to my statement about you being wrong...
Revoking my git privs and muting me on all discord channels is a weak move to avoid any fault.

i made a check if there is any mod using that and could not find any, so i merged.

Bullshit. https://github.com/draknyte1/GTplusplus/blob/master/src/Java/gtPlusPlus/core/material/ELEMENT.java#L29

@YoungGT
Copy link
Contributor Author

YoungGT commented Dec 12, 2018

OK I know it's such serious a problem that caused by me because of my poor acquaintance of Java and GT5U. I'm so sorry about it. I won't leave it, I would fix on today's evening(my evening here).
And please don't fight, please.

@Blood-Asp
Copy link
Owner

It's not a serious problem. should there be some mod using these materials they have to update their materials too, but no idea if there even one exists. otherwise i would not have merged it.

I have no problem with pointing out issues but the proper way would be to write how to do it better instead of stupidly repeating something is wrong and insulting everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Galena ore processing balance bug
3 participants