Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.09.32pre6] Advanced Circuit recipe annoyance #1556

Open
MauveCloud opened this issue Feb 4, 2020 · 2 comments
Open

[5.09.32pre6] Advanced Circuit recipe annoyance #1556

MauveCloud opened this issue Feb 4, 2020 · 2 comments

Comments

@MauveCloud
Copy link
Collaborator

When I go to check the recipes in NEI for making an HV-tier circuit with an MV-tier circuit assembler (called a Processor Assembly, using a plastic circuit board) or an EV-tier circuit assembler (called a Nanoprocessor, using an epoxy circuit board), I have to scroll past the recipe for the IC2 Advanced Circuit in an LV-tier circuit assembler (which indirectly uses phenolic circuit boards) every time, and quickly gets annoying.

I've tried searching the source code (local copy, since searching GitHub often doesn't work as well), but I haven't had much luck figuring out why this happens. Maybe somebody else will have better luck.

@MauveCloud
Copy link
Collaborator Author

Okay, possible clue: I started a new world with Mekanism included in the modlist, and now the circuit assembler recipe that would normally make an IC2 advanced circuit instead makes a Mekanism Advanced Control Circuit, at least when looking up the recipe in NEI. I haven't (yet) figured out why that happens either, but I'm guessing it's related.

@MauveCloud
Copy link
Collaborator Author

It took a little digging, but this can be fixed with a one-line change:

circuit("Circuits", "", "", true, true, false, false, false, false, false, false, false, false, 0, -1, 64, -1), // Introduced by Calclavia

That first "true" in the argument list is for "aIsUnificatable", meaning that circuits can be oredict unified (though the GregTech-specific ones have subtags to prevent that). I see no reason to unify circuits, and setting that false allows proper lookup of the Processor Assembly and Nanoprocessor (without having to scroll past the IC2 Advanced Circuit recipe).

MauveCloud added a commit to MauveCloud/GT5-Unofficial that referenced this issue Oct 28, 2020
See Blood-Asp#1556 - most (or maybe all) GT-specific circuits are already blacklisted, and I don't know of any reason to insist on unifying circuits, but this had a weird side effect described in that bug related to looking up recipes for HV-tier circuits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant