-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AssLine structure check #1226
Conversation
Listen to the BlockEvent of Reinforced Glass and trigger the update check.
@Antifluxfield did we need that for GTNH too ? |
@Dream-Master Yes. |
Try registering reinforced glass as gt casing? |
And here you have explicit warning to not do what u did (does not apply here due to class being read only unles u inject this) |
Disregard my last post looks like the only thing that needs to be changed is the addition of the glass to gt api so the state update can propagate properly trough glass (not exacly necessary since glass always touches the proper casing) |
@Technus It's ok to register the glass as a casing; but don't you think that the critical point of this issue is just what GregTech_API.java#L294 said?
When placing or breaking the reinforced glass, it doesn't trigger the upgrade. Register the block as a gt casing can only make it possible to transmit an upgrade through it; but an about-to-complete or a just-be-broken AssLine structure can always transmit a triggered upgrade to its controller. So if the glass doesn't call the causeMachineUpdate method, nothing will be fixed. |
This is why i corrected myself. Only thing that need to be done is to add the casing to gt api. |
(Add to api on top of your changes to be precise) |
That's fine. |
c40f019 3f0224f Fix AssLine structure check #1226 https://github.com/Blood-Asp/GT5-Unofficial/pull/1226/files re enable Fluid Naguadah Cells
No description provided.