Removed oredict registration of AnyIron, AnyCopper, etc. #1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1263 the AnyIron, AnyCopper, AnyBronze, AnyRubber, and AnySyntheticRubber oredict entries are easily exploitable by other mods that provide ways to unify/convert by oredict, such as JABBA barrels, the OreDictionaryConverter mod, or the Auto-Dictionary from Mariculture, while not really serving a useful purpose - players are unlikely to use wrought iron or annealed copper in recipes where the simpler versions are allowed, and both can be downgraded if that is somehow necessary.
The rubbers don't have a similar downgrade path, but there are only a small number of recipes that use them as items (rather than as molten rubber in a machine), so I split them out as separate recipes, eliminating the option to "mix and match" rubber types in a recipe, which strikes me as a strange thing to do anyway.
The AnyBronze oredict looks like it might have been a WIP that didn't get very far - only regular bronze was added to it (black bronze and bismuth bronze were left out), and the only recipe that even used this oredict entry was the alternate recipe for a vanilla Piston using a bronze ingot instead of iron.