Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed oredict registration of AnyIron, AnyCopper, etc. #1269

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

MauveCloud
Copy link
Collaborator

As discussed in #1263 the AnyIron, AnyCopper, AnyBronze, AnyRubber, and AnySyntheticRubber oredict entries are easily exploitable by other mods that provide ways to unify/convert by oredict, such as JABBA barrels, the OreDictionaryConverter mod, or the Auto-Dictionary from Mariculture, while not really serving a useful purpose - players are unlikely to use wrought iron or annealed copper in recipes where the simpler versions are allowed, and both can be downgraded if that is somehow necessary.

The rubbers don't have a similar downgrade path, but there are only a small number of recipes that use them as items (rather than as molten rubber in a machine), so I split them out as separate recipes, eliminating the option to "mix and match" rubber types in a recipe, which strikes me as a strange thing to do anyway.

The AnyBronze oredict looks like it might have been a WIP that didn't get very far - only regular bronze was added to it (black bronze and bismuth bronze were left out), and the only recipe that even used this oredict entry was the alternate recipe for a vanilla Piston using a bronze ingot instead of iron.

@Blood-Asp Blood-Asp merged commit ce4d0b7 into Blood-Asp:unstable Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants