Single block pump refactor & bugfix #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Pump will properly save it's state and reload with chunk load/reload. It remembers that it was pumping and doesn't immediately move down. Additionally, corrected saving of fluid type so it will properly look it up when it reloads 2) Fixed getYHeadOfPump() so it doesn't punch through bedrock if you destroy the pump head. If you break a gap into an existing pipe line, it will move down through the broken spots until it finds an existing set of pipes - in which case it will continue from the bottom. If you break the pump head, it will replace the last pipe with a new Head and carry on about it's business.
draknyte1
reviewed
Nov 24, 2017
| int yHead = getYOfPumpHead(); | ||
| if (yHead <= 0) { | ||
| if (yHead <= 1) { |
There was a problem hiding this comment.
This assumes flat bedrock.
There was a problem hiding this comment.
It does, but this function shouldn't otherwise punch through anything solid (the consume fluid prevents that).
This was one of the first places I changed while tracking down the bug that was punching through bedrock -- which turned out to actually be in getYHeadOfPump() which was indiscriminately replacing blocks.
draknyte1
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was having trouble with pumps downstream in the GTNH fork, figured I'd offer it up here as well if there's any interest.
Pump will properly save it's state and reload with chunk load/reload.
It remembers that it was pumping and doesn't immediately move down.
Additionally, corrected saving of fluid type so it will properly look it
up when it reloads
Fixed getYHeadOfPump() so it doesn't punch through bedrock if you
destroy the pump head. If you break a gap into an existing pipe line,
it will move down through the broken spots until it finds an existing
set of pipes - in which case it will continue from the bottom. If you
break the pump head, it will replace the last pipe with a new Head and
carry on about it's business.