Fixed Mufflers and Large Boiler Fuels. #1319
Conversation
"The Large Boiler can burn almost all forms of solid and liquid fuel, except lava." - https://ftb.gamepedia.com/Large_Boiler
Hang on. That would only be checking inside the machine for machines that require the muffler to be at the top above a hollow section. A large boiler requires the muffler hatch in the bottom layer, at which point having it face down toward an air block would not be checking inside the machine, and should be allowed. A large gas/steam turbine or large plasma generator allows the muffler hatch to be on the top, side, or bottom. If placed at the bottom, facing downward would be okay, but facing upward should be forbidden, and if placed at the side, determining which way is toward the inside of the machine would be a little trickier. |
|
No machine REQUIRES it facing downwards. Which is far more exploitable than any other direction. |
|
@draknyte1 Multimachines are cuboid. |
|
That's not universally true, but the multiblock machines that aren't cuboids don't use muffler hatches, so that seems like it will work. However, draknyte1's proposed solution seems to change whether a muffler hatch is even place-able/wrench-able to face downward, whereas checking the cuboid would have to be added to the multiblock controller (since the muffler hatch by itself doesn't know where the structure boundaries are). |
|
Then having the Controller perform muffler hatch orientation check during check machine and report incomplete structure if muffler is in wrong orientation or has output obstructed could be a valid alternative. |
|
Yeah, or, just leave the simple fix as it is. Maint. Hatches can only face horizontal, it's never caused an issue. This won't either because there is zero legitimate use for facing them down. |
|
@draknyte1
Middle turbine consume two different fuel type with its own optimal flow, so both top center blocks are occupied by input hatches. |
|
I'd rather change where hatches go on turbines than change the current status of the PR. I'll fix that tomorrow or something. |
|
The turbine has only 2 blocks of air inside. It's logical to check if the muffler is directed to one of them and that's it. |
Not really, I placed them facing down underneath my machines in the majority of cases. (I didn't actually think of facing them internally, I figured that'd already be checked for...) |
|
I somehow mean to remember that back in GT4 muffler hatches only could be placed on the top side of turbines but not sure. And as i tought so i never checked if they can work on other sides. But facing down for an exhaust actually feels wrong to me... Also about the comments to check if they face inside: The way they are currently implemented that would not be so easy. Actually can't thing about an easy way right now at all. |
|
There is no easy way, simply put. I left this as In Progress because I wanted to think of an alternative solution over the next few days. |
|
I want to remind you that the exhaust pipe of all cars is located below. |
|
And they face horizontally in all 16 countries I've visited. |
|
But none of them occupies a square meter of surface. |
|
I am just sarcastic but: |
@Blood-Asp Well at work the emergency generator exhaust faces down to prevent rain from getting in to it. And yes, pollution is denser than air. |
Fixed Mufflers and Large Boiler Fuels. (#1319) 92bcce8 Blood-Asp/GT5-Unofficial@92bcce8
Mufflers can no longer face downwards, into a machine.
This abuse allowed machines to check inside themselves for air.
Large Boilers cannot take Lava anymore, as originally intended.