Localization #1346
Merged
Localization #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last two commits fix some other l10n issues. |
mitchej123
reviewed
Dec 26, 2017
| } | ||
| } | ||
|
|
||
| protected final void addInfo(int aID) { | ||
| ItemStack tStack = new ItemStack(GregTech_API.sBlockMachines, 1, aID); |
There was a problem hiding this comment.
You should add server side protection here, otherwise if someplace calls this without the check it'll crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1251 , I introduced the "%material" placeholder to better support localization; but seems that it doesn't work well as what I thought in some languages. Though you can overwrite the placeholder if necessary, the lang file is not that readable anymore. Thus, as a simple solution, I add a config to disable this placeholder in this PR.