Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drain/fill to take into account pipe connections #1371

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Update drain/fill to take into account pipe connections #1371

merged 1 commit into from
Feb 10, 2018

Conversation

mitchej123
Copy link
Contributor

This should stop things (output hatch, for example) from moving fluid into unconnected adjacent fluid pipes.

Additionally consolidated the logic into a helper function.

@draknyte1
Copy link
Collaborator

draknyte1 commented Jan 9, 2018

Things like Fluid Output Hatches are intended to automatically output their contents, iirc.
Are you talking pipes like this?

X: Casing
O: Output Hatch
P: Pipe

XX
XOPPP
  P<-- this one?

@mitchej123
Copy link
Contributor Author

mitchej123 commented Jan 9, 2018

They are currently outputting to unconnected fluid pipes; this requires a fluid pipe be connected before they can be output to. It doesn't change the behavior of anything else in front of the fluid output hatch, or the behavior of connected pipes.

I'm not sure what your diagram is trying to illustrate.

@mitchej123
Copy link
Contributor Author

Here's some screenshots to illustrate what I changed:

This previously output (but in my mind shouldn't since the pipe isn't connected):
should_not_output

This previously output (and still does, since the pipe is connected):
should_output

@Blood-Asp Blood-Asp merged commit 2b21b51 into Blood-Asp:unstable Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants