Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1406 #1413

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Fixed #1406 #1413

merged 2 commits into from
Apr 11, 2018

Conversation

Dimach
Copy link
Contributor

@Dimach Dimach commented Mar 11, 2018

No description provided.

@draknyte1
Copy link
Collaborator

Can you please write a description next time?
I don't care if it's a single line PR that is obvious, I set guidelines and expect people to follow them.

@Dream-Master
Copy link

@draknyte1 is this important for GTNH too?

@draknyte1
Copy link
Collaborator

@Dream-Master your best bet would be to ask whoever has managed the pipe fixes in your fork so far. But I'd assume you'd want it merged if it's applicable.

@SapientMC
Copy link

@draknyte1 It's the fix for error in this PR #1378

@draknyte1
Copy link
Collaborator

I'm aware what it is. But there's PR guidelines for a reason.. so we don't have to read the code to know what the fuck things do..

I want to read code to review it, not to understand what you're trying to PR..

@SapientMC
Copy link

@draknyte1 PR #1378 fixed bug with fluid distribution to more than 3 different ways. And added new fluid distribution mechanics: larger pipe gets more.
But added 2 new bugs.

  1. In some cases fluid do not go into one of pipe at the fork at all.
  2. Steam does not loads to machine from top side.

This PR fixes both of them and simplifies fluid distribution: equally to all consumers.

Fixed bug when pipes sometimes cant insert steam into steam machines.
@Blood-Asp Blood-Asp merged commit b397aba into Blood-Asp:unstable Apr 11, 2018
@Dimach Dimach deleted the fixPipes branch June 13, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants