-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magical Energy Absorber fix stop drain and rework Vis to EU Conversion #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New configuration option to define how much EU Per Vis (not CVis) I:EnergyPerVis_20=20 This value is divided by 100, so it is actually 0.2 EU per Vis The Magical Energy Absorber will try to drain enough CVis, comulating all aspects, until it can reach max Output, or has drained all available aspects. Number of total cummulated CVis output required in a Node per Magical Energy Absorber Tier: Novice (LV): √(32 × 10000 ÷ (20 × 90)) = 13,333333333 ⇒ 13 CVis Adept (MV); √(128 × 10000 ÷ (20 × 80)) = 28,2843 ⇒ 28 CVis Master (HV): √(512 × 10000 ÷ (20 × 70)) = 60,474315681 ⇒ 60 CVis Grand Master (EV): √(2048 × 10000 ÷ (20 × 60)) = 130,639452948 ⇒ 131 CVis As referrence: The Huge Creative Node from Thaumcraft has 500 of each primal aspects.
Build with this PR has been tested and working as expected. |
draknyte1
approved these changes
Jul 16, 2018
bartimaeusnek
approved these changes
Jul 28, 2018
- Fixed Dragon Egg Siphon mode to work as intended when `B:MagicEnergyAbsorber.AllowMultipleEggs_false=false` (fix #1482) - Fixed Vis drain from Visnet (Energized Node/Vis Relay) drain rate (fix #1119) - Added Vis conversion as a configuration option: `I:MagicEnergyAbsorber.EnergyPerVis_20=20` - Replaced broken Aspect drain from items, with drain from Essentia Containers in range, using same mechanic as the Infusion Altar - Added Essentia Aspect conversion as a configuration option: `I:MagicEnergyAbsorber.EnergyPerEssentia_320=320` - Fixed Enchantments drain to convert all available enchantments - Made input filtered to valid enchanted items/books (Item must be enchantable and enchanted) - Fixed Enchantments drain to not consume input; if it can not buffer generated energy from it, or if it can not output disenchanted item - Added a user settable Tiered operation range using a Screwdriver. Default Range Tier is Machine Tier. Max Range Tier is Machine Tier + 2. Range is 2^(Range Tier): 1, 2, 4, 8, 16, 32, 64 blocks - Fixed Ender Crystal drain mechanic, to allow multiple Crystals to be drained. - Made each in-use Ender Crystal, exclusive to a Magic Energy Absorber - Improved default Ender Crystal energy worth to 512EU/t instead of 32EU/t
Dream-Master
referenced
this pull request
in GTNewHorizons/GT5-Unofficial
Oct 7, 2018
Magical Energy Absorber fix stop drain and rework Vis to EU Conversion ( #1478) * fix(magicalenergyabsorber) stops when buffer can not store the next maximum eu output * rework(magicalenergyabsorber): computation of vis to eu conversion New configuration option to define how much EU Per Vis (not CVis) I:EnergyPerVis_20=20 This value is divided by 100, so it is actually 0.2 EU per Vis The Magical Energy Absorber will try to drain enough CVis, comulating all aspects, until it can reach max Output, or has drained all available aspects. Number of total cummulated CVis output required in a Node per Magical Energy Absorber Tier: Novice (LV): √(32 × 10000 ÷ (20 × 90)) = 13,333333333 ⇒ 13 CVis Adept (MV); √(128 × 10000 ÷ (20 × 80)) = 28,2843 ⇒ 28 CVis Master (HV): √(512 × 10000 ÷ (20 × 70)) = 60,474315681 ⇒ 60 CVis Grand Master (EV): √(2048 × 10000 ÷ (20 × 60)) = 130,639452948 ⇒ 131 CVis As referrence: The Huge Creative Node from Thaumcraft has 500 of each primal aspects. * fix(machine): magic energy absorber - Fixed Dragon Egg Siphon mode to work as intended when `B:MagicEnergyAbsorber.AllowMultipleEggs_false=false` (fix #1482) - Fixed Vis drain from Visnet (Energized Node/Vis Relay) drain rate (fix #1119) - Added Vis conversion as a configuration option: `I:MagicEnergyAbsorber.EnergyPerVis_20=20` - Replaced broken Aspect drain from items, with drain from Essentia Containers in range, using same mechanic as the Infusion Altar - Added Essentia Aspect conversion as a configuration option: `I:MagicEnergyAbsorber.EnergyPerEssentia_320=320` - Fixed Enchantments drain to convert all available enchantments - Made input filtered to valid enchanted items/books (Item must be enchantable and enchanted) - Fixed Enchantments drain to not consume input; if it can not buffer generated energy from it, or if it can not output disenchanted item - Added a user settable Tiered operation range using a Screwdriver. Default Range Tier is Machine Tier. Max Range Tier is Machine Tier + 2. Range is 2^(Range Tier): 1, 2, 4, 8, 16, 32, 64 blocks - Fixed Ender Crystal drain mechanic, to allow multiple Crystals to be drained. - Made each in-use Ender Crystal, exclusive to a Magic Energy Absorber - Improved default Ender Crystal energy worth to 512EU/t instead of 32EU/t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1119
Stop draining CVis once buffer can not hold another Max Output
Rework computation of Vis to EU conversion
I:EnergyPerVis_20=20
This value is divided by 100, so it is actually 0.2 EU per Vis.
until it can reach max Output, or has drained all available aspects.
Reference Documentation
Number of total cumulated CVis output required in a Node per Magical Energy Absorber Tier:
Novice (LV):
√((32 ÷ (20 ÷ 100)) ÷ 0.9) = 13,333333333 ⇒ 13 CVis
Adept (MV);
√((128 ÷ (20 ÷ 100)) ÷ 0.8) = 28,2843 ⇒ 28 CVis
Master (HV):
√((512 ÷ (20 ÷ 100)) ÷ 0.7) = 60,474315681 ⇒ 60 CVis
Grand Master (EV):
√((2048 ÷ (20 ÷ 100)) ÷ 0.6) = 130,639452948 ⇒ 131 CVis
An LV Absorber needing 13 CVis/t total of max 6 aspects:
13² = 169. You will need a node with a total of 169 aspects count to be able
to output enough CVis for LV power. 169 / 6. It means 28 or 29 of each primal aspects.
An EV Absorber needing 131 CVis/t will drain an average of 484 of each aspect to
sustain a 2048 EU/t output.
As reference:
The Huge Creative Node from Thaumcraft has 500 of each primal aspects and would be suitable tu power a Grand Master Magical Energy Absorber.