Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some fixes for old bugs #1529

Merged
merged 9 commits into from
Jun 16, 2019
Merged

Added some fixes for old bugs #1529

merged 9 commits into from
Jun 16, 2019

Conversation

AndreySolodovnikov
Copy link
Contributor

This PR includes
1.fix for HV and LV circuits that cannon be put in any machine
2.fix for assembly line books and data sticks on server
3,fix for automaintance hatch. Now it can hold only 1 stack of each item that it needs for maintating

now LuV+ Conveyors can work with more than 1 stack per tick
Added a fix for unlocalized item names in AL books at minecraft servers
Automaintance hatches cannot be used for automainting if they allow to put in any items. This fix changes this, now automaintance hatches can hold only 1 stack of each needed for maintating item
fixed old bug when LV and HV circuits cannot be automatically put in any machines
This reverts commit 467563b.
@Blood-Asp
Copy link
Owner

hmm, after so long some work done again.

guess i have to find some free time to check PRs soon again

Copy link
Collaborator

@draknyte1 draknyte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AL server stuff is not required. Consult the GTNH fork.
Hard coding scanner recipes for GC blueprints is also a no.

Will review rest later today.

@SapientMC
Copy link

@draknyte1 Could you express in more detail?
Our level of English does not allow us to understand exactly what is wrong.

@Blood-Asp
Copy link
Owner

@SapientMC pretty sure he means: GT New Horizon has already done a fix for the Assemblyline on servers that works without all that duplicate code. checking out how it is done there and porting it over here is the preferred way.
And i fully agree that seperated client/server code for machines is a bad idea.

The part about the Galacticraft blueprints should be on point and clear...

@AndreySolodovnikov
Copy link
Contributor Author

@draknyte1 NH fork has almost same fix for AL books. Should I just use previous commit, without ALServer stuff? GTNewHorizons/GT5-Unofficial@3e5b4f6#diff-8e7d8a5ff9ea320069c1742efa0220b2 this commit adds ALServer . Or should I port only this commit GTNewHorizons/GT5-Unofficial@8ce5ad6#diff-8e7d8a5ff9ea320069c1742efa0220b2

@draknyte1
Copy link
Collaborator

Port whatever they did, it works, it’s tested..

@AndreySolodovnikov
Copy link
Contributor Author

Well I've ported that.. and I copied GT-Scanner class accidently copied GC patterns part, I can delete it, then my PR will become port of GTNH AL fix

now this is the port of NH fork fix
@AndreySolodovnikov
Copy link
Contributor Author

Updated, deleted GC patterns. now AL fix is same with this commit GTNewHorizons/GT5-Unofficial@3e5b4f6#diff-8e7d8a5ff9ea320069c1742efa0220b2

@Blood-Asp Blood-Asp merged commit aa577dd into Blood-Asp:unstable Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants