-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some fixes for old bugs #1529
Conversation
now LuV+ Conveyors can work with more than 1 stack per tick
Added a fix for unlocalized item names in AL books at minecraft servers
Automaintance hatches cannot be used for automainting if they allow to put in any items. This fix changes this, now automaintance hatches can hold only 1 stack of each needed for maintating item
fixed old bug when LV and HV circuits cannot be automatically put in any machines
This reverts commit 467563b.
This reverts commit 4dc2e21.
hmm, after so long some work done again. guess i have to find some free time to check PRs soon again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AL server stuff is not required. Consult the GTNH fork.
Hard coding scanner recipes for GC blueprints is also a no.
Will review rest later today.
@draknyte1 Could you express in more detail? |
@SapientMC pretty sure he means: GT New Horizon has already done a fix for the Assemblyline on servers that works without all that duplicate code. checking out how it is done there and porting it over here is the preferred way. The part about the Galacticraft blueprints should be on point and clear... |
@draknyte1 NH fork has almost same fix for AL books. Should I just use previous commit, without ALServer stuff? GTNewHorizons/GT5-Unofficial@3e5b4f6#diff-8e7d8a5ff9ea320069c1742efa0220b2 this commit adds ALServer . Or should I port only this commit GTNewHorizons/GT5-Unofficial@8ce5ad6#diff-8e7d8a5ff9ea320069c1742efa0220b2 |
Port whatever they did, it works, it’s tested.. |
Well I've ported that.. and I copied GT-Scanner class accidently copied GC patterns part, I can delete it, then my PR will become port of GTNH AL fix |
now this is the port of NH fork fix
Updated, deleted GC patterns. now AL fix is same with this commit GTNewHorizons/GT5-Unofficial@3e5b4f6#diff-8e7d8a5ff9ea320069c1742efa0220b2 |
This PR includes
1.fix for HV and LV circuits that cannon be put in any machine
2.fix for assembly line books and data sticks on server
3,fix for automaintance hatch. Now it can hold only 1 stack of each item that it needs for maintating