-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid stacks include more detailed quantities #1581
base: unstable
Are you sure you want to change the base?
Conversation
Syncing from original.
Originally by moller21 in GTNH and improved by bartimaeusnek
Java 1.7 compatible version of baritmaeusnek's GTNH fix to this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you on discord at all?
There’s many small QoL things we’ve done to GTNH that could do with a PR to master.
I rarely get on discord anymore, but I do have an account. (I peeked at the GT++ channel via the web interface recently to find out that I could get a newer version out of GTNH than is on CurseForge) |
@MauveCloud http://jenkins.usrv.eu:8080/job/Gregtech-5-Unofficial/ |
@Dream-Master not quite what I meant - I was grabbing GT++ out of GTNH, not the GT build. @draknyte1 if you want me to hop on discord, please let me know which channel to enter (I don't think GitHub provides a way for you to message me privately, so if you want to do that with a discord invite, I suggest you do so via the IC2 forum), or alternatively you could add a comment to my "small fixes" PR with some links to the GTNH PRs/commits that you want me to copy to main GT5u (I'm guessing there are changes in GTNH that probably shouldn't be copied over) Edit: if you do neither within a week (i.e. by November 7), I plan to open and immediately close a PR from the GTNH GT5u repo, so I can look over the differences myself at leisure. |
This one done and dusted? |
Yes. |
See GTNewHorizons/GT5-Unofficial#258 and GTNewHorizons/GT5-Unofficial#286
Originally by moller21 with improvements by bartimaeusnek in GTNH, but I thought this was worth copying to main GT5u.