Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache of hdf5 and libaes source #481

Merged
merged 12 commits into from
Dec 11, 2023
Merged

add cache of hdf5 and libaes source #481

merged 12 commits into from
Dec 11, 2023

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Nov 23, 2023

No description provided.

@mgeplf mgeplf force-pushed the mac-silicon branch 10 times, most recently from 191a74b to 70f9d92 Compare November 27, 2023 12:44
@mgeplf mgeplf force-pushed the mac-silicon branch 19 times, most recently from 15df144 to 46b59ca Compare November 28, 2023 13:42
@mgeplf mgeplf force-pushed the mac-silicon branch 5 times, most recently from bdbc2ef to 14f8d25 Compare November 30, 2023 09:20
@mgeplf mgeplf force-pushed the mac-silicon branch 3 times, most recently from 077a496 to 4275f12 Compare December 1, 2023 15:01
with:
python-version: '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just jump to 3.10 so that we don't have to change it soon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

ldconfig
popd

# CMake complains if the dependencies come from within the same tree
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense, just doesn't matter in our case - I think usually it would

Copy link
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@mgeplf mgeplf merged commit 753ba1f into master Dec 11, 2023
20 checks passed
@mgeplf mgeplf deleted the mac-silicon branch December 11, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants