Proposal for v4 composite types #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adrien-berchet
commented
May 1, 2023
adrien-berchet
force-pushed
the
abe/v4-composite-types
branch
from
fc7fc32 to
6fee616
Compare
adrien-berchet
force-pushed
the
abe/v4-composite-types
branch
2 times, most recently
from
07cfb98 to
4729f15
Compare
adrien-berchet
force-pushed
the
abe/v4-composite-types
branch
from
4729f15 to
a12dc2f
Compare
adrien-berchet
commented
May 2, 2023
adrien-berchet
force-pushed
the
abe/v4-composite-types
branch
from
d2a6509 to
3c98024
Compare
adrien-berchet
commented
Jun 5, 2023
There was a problem hiding this comment.
Interesting!
So if I'm correct you discarded the following features:
- get neurite types by name using the ctor (e.g.
NeuriteType("axon")) - represent unknown types (since there is no dedicated subtype)
- pass several types to
neurom.features.neurite._map_sections
Did I miss anything?
| ((3, 2), "<NeuriteType.axon_carrying_dendrite: (3, 2)>"), | ||
| ], | ||
| ) | ||
| def test_neurite_type__repr(value, expected): |
There was a problem hiding this comment.
You don't like nested tests? Sometimes it's convenient to run only the tests of the NeuriteType for example.
There was a problem hiding this comment.
Not so much, no. I prefer a flat listing of the tests, but this is a matter of preference mostly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation of #1067