Add has_no_root_node_jumps check #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the neurites have their first point not further than `radius_multiplier * soma radius` from the soma center'''
|
This is required for the validator web service I've been asked to build |
wizmer
commented
Jul 9, 2019
| @@ -223,6 +223,19 @@ def has_no_jumps(neuron, max_distance=30.0, axis='z'): | |||
| return CheckResult(len(bad_ids) == 0, bad_ids) | |||
|
|
|||
|
|
|||
| def has_no_root_node_jumps(neuron, radius_multiplier=2): | |||
There was a problem hiding this comment.
Not sure about the name of the function
There was a problem hiding this comment.
Not sure about the name radius_multiplier
There was a problem hiding this comment.
I can't think of better names
mgeplf
approved these changes
Jul 10, 2019
| @@ -223,6 +223,19 @@ def has_no_jumps(neuron, max_distance=30.0, axis='z'): | |||
| return CheckResult(len(bad_ids) == 0, bad_ids) | |||
|
|
|||
|
|
|||
| def has_no_root_node_jumps(neuron, radius_multiplier=2): | |||
There was a problem hiding this comment.
I can't think of better names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the neurites have their first point not further than
radius_multiplier * soma radiusfrom the soma center'''