Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include fmt/ranges.h for using fmt::join() #360

Merged
merged 1 commit into from
Jul 22, 2024
Merged

include fmt/ranges.h for using fmt::join() #360

merged 1 commit into from
Jul 22, 2024

Conversation

tchaikov
Copy link
Contributor

fmt::join() was moved into fmt/ranges.h in fmt 11, so let's include this header file also.

@tchaikov
Copy link
Contributor Author

tchaikov commented Jul 21, 2024 •
edited
Loading

hi @WeinaJi @mgeplf could you help review this change at your convenience? i see you've been contributing to this project, so wondered if you could help on this change.

@tchaikov
include fmt/ranges.h for using fmt::join()
854b40c 
fmt::join() was moved into fmt/ranges.h in fmt 11, so let's include
this header file also.

Signed-off-by: Kefu Chai <[email protected]>
@mgeplf
Copy link
Contributor

mgeplf commented Jul 22, 2024

Thanks for the change.

@mgeplf mgeplf merged commit 919be1f into BlueBrain:master Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeplf mgeplf mgeplf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchaikov @mgeplf