Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize synapse loading. #68

Closed
wants to merge 3 commits into from
Closed

Optimize synapse loading. #68

wants to merge 3 commits into from

Conversation

1uc
Copy link
Contributor

@1uc 1uc commented Oct 23, 2023

Context

Reading synapses from edge files is done in many small, scattered reads.

Scope

  1. Replace RoundRobin with the better alternative.
  2. Combine small edge ID ranges into larger ranges, read, then extract.
  3. Temporarily, turn off advanced load-balancing.

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@1uc
Copy link
Contributor Author

1uc commented Oct 23, 2023

This is a WIP. The intention is to create an short-term release that can be used in simulations that have a large impact on GPFS. Therefore, the following topics are out-of-scope:

  • Memory usage in pathological cases.
  • Code organization, e.g. moving functionality to libsonata.
  • Docstrings and unit-testing.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc changed the title 1uc/hotfix edge loading Optimize synapse loading. Oct 23, 2023
@1uc
Copy link
Contributor Author

1uc commented Oct 23, 2023

The corresponding libsonata changes: BlueBrain/libsonata#298

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/hotfix-edge-loading branch 3 times, most recently from c67ef5a to eef0918 Compare October 23, 2023 15:32
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/hotfix-edge-loading branch 2 times, most recently from 597f7fe to fa1eb33 Compare October 23, 2023 17:28
Luc Grosheintz added 3 commits October 23, 2023 19:39
This implements merging of edge IDs, reading larger chunks, then
extracting the required data.

The current implementation is a WIP, and has a few obvious weaknesses.
Advanced load balancing scatters node ids. However, contiguous node IDs is a
prerequisite for merge-read-extract to work. Moreover, if the node IDs are
highly scattered the current implementation will likely go OOM.
@1uc 1uc force-pushed the 1uc/hotfix-edge-loading branch from fa1eb33 to 42478a6 Compare October 23, 2023 17:44
@bbpbuildbot
Copy link

Logfiles from GitLab pipeline #164280 (:no_entry:) have been uploaded here!

Status and direct links:

@1uc 1uc closed this Oct 30, 2023
@1uc 1uc deleted the 1uc/hotfix-edge-loading branch October 30, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants