Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HOC/Python wrapper printing. #1522

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Refactor HOC/Python wrapper printing. #1522

merged 7 commits into from
Oct 22, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Oct 18, 2024

The method is first split into three parts:

  • determining the signature,
  • printing the setup code,
  • calling the implementation.

Additionally we rename the function, because it doesn't print the function body, it prints the whole wrapper function.

@1uc 1uc force-pushed the 1uc/refactor-hocpy branch from fbe64de to 844bcbe Compare October 18, 2024 08:25
@1uc 1uc marked this pull request as ready for review October 18, 2024 09:00
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.hpp Outdated Show resolved Hide resolved
src/codegen/codegen_neuron_cpp_visitor.cpp Show resolved Hide resolved
@1uc 1uc merged commit 380207b into master Oct 22, 2024
12 checks passed
@1uc 1uc deleted the 1uc/refactor-hocpy branch October 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants