Fix potential deadlock in waitUntilFinished. (#268)

BoltsFramework · Jul 12, 2016 · ce65a75 · ce65a75
1 parent eaba419
commit ce65a75
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Bolts/Common/BFTask.m b/Bolts/Common/BFTask.m
@@ -523,7 +523,9 @@ - (void)waitUntilFinished {
         }
         [self.condition lock];
     }
-    while (!self.completed) {
+    // TODO: (nlutsenko) Restructure this to use Bolts-Swift thread access synchronization architecture
+    // In the meantime, it's absolutely safe to get `_completed` aka an ivar, as long as it's a `BOOL` aka less than word size.
+    while (!_completed) {
         [self.condition wait];
     }
     [self.condition unlock];