Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBSDKCoreKit 4.10.0 is forcing Bolts 1.6 through CocoaPods, using a faulty waitUntilFinished method on BFTask #257

Closed
marcosjvivar opened this issue Jun 22, 2016 · 4 comments

Comments

@marcosjvivar
Copy link

Regarding the Facebook iOS SDK https://github.com/facebook/facebook-ios-sdk (as FBSDKCoreKit through CocoaPods), the version 4.10.0 is forcing Bolts (https://github.com/BoltsFramework/Bolts-ObjC) to its version 1.6 (SHA d293c44).

In the BFTask class, the method - (void)waitUntilFinished has a faulty behaviour which is recurrently causing a crash.
I tried to force a pod update Bolts but the FBSDKCoreKit 4.10.0 version is stopping it from updating.

Is there a way to force a CocoaPods update for Bolts from 1.6.0 to 1.7.0 without updating FBSDKCoreKit to the latest version of it which supports that required version of Bolts?

@nlutsenko
Copy link
Member

Not sure how this is relevant to Bolts, tbh.

FBSDKCoreKit 4.10 depends on Bolts version ~>1.5 aka 1.5 or later, but not 2.0, which includes the latest version of Bolts. (as you can observe here)

More than that, waitUntilFinished wasn't changed between two 1.6.0 and 1.7.0.
If you can post a stack trace for the crash or get us more information - that would be very helpful to identify the core problem.

@marcosjvivar
Copy link
Author

I hope this stack trace of the crash throws more light about it:
On Thread 31
#0 0x0000000181acbf24 in __psynch_cvwait ()
#2 0x0000000182872324 in -NSCondition wait
#3 0x0000000100b13cd8 in -[BFTask waitUntilFinished] at /BFTask.m:502
#4 0x00000001010c4580 in -[BFTask(Private) waitForResult:withMainThreadWarning:] at /BFTask+Private.m:113
#5 0x00000001010c4530 in -[BFTask(Private) waitForResult:] at /BFTask+Private.m:108
#6 0x00000001010fa180 in -[PFEventuallyQueue _runCommandsWithRetriesCount:] at /PFEventuallyQueue.m:251
#7 0x00000001010f9ce0 in -[PFEventuallyQueue _runCommands] at /PFEventuallyQueue.m:215
#8 0x00000001010f98c0 in __26-[PFEventuallyQueue start]_block_invoke at /PFEventuallyQueue.m:180

screen shot 2016-06-22 at 16 29 28

@nlutsenko
Copy link
Member

The stack trace definitely helps, but I don't think it's a crash in this case, but rather I can see that you manually stopped it.

I would recommend filing a report on the exact conditions on when this happens on the Parse SDK repo, since it's not a bug in Bolts, but likely to be one in Parse SDK.

@marcosjvivar
Copy link
Author

Hi @nlutsenko
I did not manually stop. The application crashes there but I removed the console log because of sensitive information regarding the application.
I will fill a report on Parse in order to find out the reason if this crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants