Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot-syntax support. #8

Closed
wants to merge 1 commit into from
Closed

Conversation

inamiy
Copy link

@inamiy inamiy commented Feb 4, 2014

It'll be lovely if this library can support dot-syntax :)

@bklimt
Copy link
Contributor

bklimt commented Feb 6, 2014

This is a very neat trick. I like the way it lets you write a sequence of tasks without having a jumble of "[[[[" at the beginning. Unfortunately, I don't think we'll be able to merge this pull request. Our primary concerns are:

  1. The Objective-C community will likely object to this non-standard syntax that feels a bit like trying to imitate the Java style.
  2. Having continueWithBlock: mutate the BFTask that it is called on in an observable way is unintuitive, and does not feel like it's in the spirit of what a Task represents.
  3. There is a known issue with including categories in libraries that causes linker failures when not using the -ObjC flag. However, using -ObjC has its own set of problems. So we are going to avoid using categories in Bolts for the time being. For more information, see https://developer.apple.com/library/mac/qa/qa1490/_index.html

Thanks again for taking the time to put this together.

@bklimt bklimt closed this Feb 6, 2014
@inamiy
Copy link
Author

inamiy commented Feb 7, 2014

All right. Thanks for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants