Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when creating a BFURL when target_url is null. #128

Merged
merged 1 commit into from
Aug 29, 2015

Conversation

nlutsenko
Copy link
Member

Verify that the string is actually a string. This eliminates potential problems like if the URL is a number or anything else shady.
Fixes #114.

@grantland
Copy link
Member

LGTM

@grantland grantland assigned nlutsenko and unassigned grantland Aug 29, 2015
nlutsenko added a commit that referenced this pull request Aug 29, 2015
Fixed crash when creating a BFURL when target_url is null.
@nlutsenko nlutsenko merged commit 71b69e7 into master Aug 29, 2015
@nlutsenko nlutsenko deleted the nlutsenko.targetURL branch August 29, 2015 00:53
@facebook-github-bot
Copy link
Contributor

@nlutsenko updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants