-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward compatible Obj-C Generic support for Tasks. #136
Conversation
LGTM |
Do we not have to update the implementation files? |
Aha, I am glad you asked - the answer is actually |
lol nice |
2b5563d
to
0c9840f
Compare
I've just updated the PR, so we have covariant support on this. BFTask<NSString *> *stringTask = [BFTask taskWithResult:[NSString string]];
BFTask<NSMutableString *> *mutableStringTask = [BFTask taskWithResult:[NSMutableString string]];
stringTask = mutableStringTask; // This is valid, since NSMutableString is a subclass of NSString |
<3 covariants.
|
even better! |
e4d03d3
to
542bc46
Compare
Add backward compatible Obj-C Generic support for Tasks.
@nlutsenko updated the pull request. |
This support latest syntax in Xcode 7, and also is backward compatible via macro.
cc @grantland, @hallucinogen, @richardjrossiii