-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tvOS build target #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<BuildableReference | ||
BuildableIdentifier = "primary" | ||
BlueprintIdentifier = "F5AFC9EA1BA752750076E927" | ||
BuildableName = "TVBolts.framework" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong, it should just be Bolts.framework
.
Can you try regenerating the scheme?
Generally looks great, throwing in some thoughts for discussion. |
richardjrossiii
force-pushed
the
tvos
branch
from
September 14, 2015 23:00
748b6c9
to
88c2078
Compare
richardjrossiii
force-pushed
the
tvos
branch
from
September 14, 2015 23:08
88c2078
to
64390a2
Compare
LGTM. Ship! |
richardjrossiii
force-pushed
the
tvos
branch
from
September 14, 2015 23:15
64390a2
to
f57b6af
Compare
Includes unit tests.
richardjrossiii
force-pushed
the
tvos
branch
from
September 15, 2015 01:30
f57b6af
to
cb9750d
Compare
richardjrossiii
added a commit
that referenced
this pull request
Sep 17, 2015
Added tvOS build target
@richardjrossiii updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test target, framework target, and updated build scripts.
Only includes files included in MacBolts, (no app links, etc.)
Cannot add to travis until we have the latest Xcode beta available there.