Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nullability annotations to Bolts Tasks. #162

Merged
merged 5 commits into from
Oct 29, 2015

Conversation

nlutsenko
Copy link
Member

Closes #161

This pull request adds nullability annotations to Bolts Tasks.
Few highlights:

  • This is somewhat potentially breaking, since there are no more implicitly unwrapped optionals in Swift after this is done
  • This will work on any Xcode 6.3.1+ (which is going to be a requirement after this is merged in) (I can make it support versions before, but it will get way more polluted, and not sure on the actual impact)
  • For qualifiers - this is still using __nullable instead of _Nullable, since the latter is available on Xcode 7.0+ only

Everything is split into separate commits for easier review, will squash later.

cc @grantland @hallucinogen

@nlutsenko nlutsenko force-pushed the nlutsenko.nullability branch from c30565d to 3c884d8 Compare October 29, 2015 03:58
nlutsenko added a commit that referenced this pull request Oct 29, 2015
Added nullability annotations to Bolts Tasks.
@nlutsenko nlutsenko merged commit a523b10 into master Oct 29, 2015
@nlutsenko nlutsenko deleted the nlutsenko.nullability branch October 29, 2015 04:12
@arielelkin
Copy link

👍

@facebook-github-bot
Copy link
Contributor

@nlutsenko updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants