[scripts] Have test paths match execution paths
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build script tests that developer tools exist at certain paths by using `test "$FOO"`--note the quotes around `$FOO`. When invoking those tools, on the other hand, the paths to the tools are *not* wrapped in quotes. This causes script failures when the paths include spaces. Wrap the tool paths in quotes, to match how they are tested.
|
Awesome. Will merge in after travis passes. Thanks for fixing it! |
nlutsenko
added a commit
that referenced
this pull request
Oct 12, 2015
[scripts] Have `test` paths match execution paths
|
@modocache updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script tests that developer tools exist at certain paths by
using
test "$FOO"--note the quotes around$FOO. When invoking thosetools, on the other hand, the paths to the tools are not wrapped in
quotes. This causes script failures when the paths include spaces.
Wrap the tool paths in quotes, to match how they are tested.