+[BFTask taskFromExecutor:withBlock] to easily create ad-hoc tasks #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we review this, would you mind accepting the Facebook contributor license agreement so that we can give you proper attribution if we merge it in? We would really appreciate it. Thanks! |
|
A short while after submitting this diff I filled out the CLA so everything should be set. |
|
Our automated systems don't show that you have accepted the CLA. Would you mind double-checking it? |
|
Sure thing - I signed it again. |
This convenience class method makes it easier to create tasks from blocks
without needing to write the code for a temporary `BFTask` or
`BFTaskCompletionSource`. Usage:
[[BFTask taskFromExecutor:executor withBlock:id ^{
return work_on_queue();
}] continueWithBlock:...];
As opposed to:
BFTaskCompletionSource *tcs = [BFTaskCompletionSource taskCompletionSource];
dispatch_async(queue, ^{
[tcs setResult:work_on_queue()];
});
[tcs.task continueWithBlock:...];
The convenience method also handles exceptions the same way the rest of BFTasks
does so that's another plus.
Test case is included.
|
LGTM. Thanks for the contribution! |
bklimt
added a commit
that referenced
this pull request
May 30, 2014
+[BFTask taskFromExecutor:withBlock] to easily create ad-hoc tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This convenience class method makes it easier to create tasks from blocks
without needing to write the code for a temporary
BFTaskorBFTaskCompletionSource. Usage:As opposed to:
The convenience method also handles exceptions the same way the rest of BFTasks
does so that's another plus.
Test case is included.