Fix disposing of CancellationTokenSource with registrations. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.cancellationToken
branch
from
baa7684 to
37d6aa8
Compare
nlutsenko
force-pushed
the
nlutsenko.cancellationToken
branch
from
37d6aa8 to
77a6c98
Compare
nlutsenko
added a commit
that referenced
this pull request
Feb 3, 2016
Fix disposing of CancellationTokenSource with registrations.
|
@nlutsenko updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have registered at least 1 registration for the cancellation token and trying to dispose it - it will crash,
as we are enforcing that the disposal of registration happens before the disposal of cancellation token source,
even in case of internal API usage.