Define constant variables for multiple {errors, exceptions} userInfo keys #238
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
chuganzy
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -29,6 +29,9 @@ extern NSInteger const kBFMultipleErrorsError; | |||
| */ | |||
| extern NSString *const BFTaskMultipleExceptionsException; | |||
|
|
|||
| extern NSString *const BFTaskMultipleErrorsUserInfoKey; // NSArray<NSError *> | |||
There was a problem hiding this comment.
Can we document this the same way as other constants documented?
This will translate in a better auto-generated documentation.
|
Looks great outside of documentation, thanks for doing this. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@nlutsenko Updated the document ⭐ |
|
|
||
| /*! | ||
| An error userInfo key used if there were multiple exceptions on <BFTask taskForCompletionOfAllTasks:>. | ||
| Value type is `NSArray<NSException *> *`. |
There was a problem hiding this comment.
Nit: There is an extra space between is and type.
|
One more nit and it's good to go. |
|
Will merge as soon as Travis passes. |
Define constant variables for multiple {errors, exceptions} userInfo keys
|
@hoppenichu updated the pull request. |
No description provided.