Mark classes and methods unavailable for extensions #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-dumit
commented
Nov 29, 2016
| @@ -143,7 +143,7 @@ - (BFTask *)followRedirects:(NSURL *)url { | |||
| }]; | |||
| } | |||
|
|
|||
| - (BFTask *)appLinkFromURLInBackground:(NSURL *)url { | |||
| - (BFTask *)appLinkFromURLInBackground:(NSURL *)url NS_EXTENSION_UNAVAILABLE_IOS("") { | |||
There was a problem hiding this comment.
I had to add this here on top of adding it to the method definition in the BFAppLinkResolving protocol otherwise it would still complain.
nlutsenko
approved these changes
Jan 3, 2017
|
Hey Felix, looks like this is failing some Travis tests... |
|
@nlutsenko Ok just did 👍 |
laptobbe
pushed a commit
to prion-app/Bolts-ObjC
that referenced
this pull request
Apr 28, 2017
* mark classes and methods unavailable for extensions * Add BFVoid macro. * Update BFTask.taskWithDelay to use BFVoid. * Update xctoolchain to latest. * Update projects to Xcode 8.2. * Use Xcode 8.2 for Travis-CI. * Remove automatic exception catching. (BoltsFramework#294)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly relevant to when using cocoapods, as of version
1.1.0you can no longer have a Podfile with a different subspec for the app target and extensions, i.e:So the solution is to use
pod 'Bolts'for both targets.In order to do that some methods/classes need to be marked as unavailable so the app is compilable.