Fixed potential crash in BFAppLinkReturnToRefererController when it is initialized without navigation controller. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s initialized without navigation controller.
grantland
added a commit
that referenced
this pull request
Aug 20, 2014
Fixed potential crash in BFAppLinkReturnToRefererController when it is initialized without navigation controller.
ghost
deleted the
|
@ghost updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we are removing NSNotificationCenter observation, only in case when there was the controller was initialized with navigation controller - whilst this is not the only way you can initialize the
BFAppLinkReturnToRefererController.removeObserver:name:object:is slower than justremoveObserver:, as it performs unnecessary lookups)