Update Bolts to work on OS X 10.10 and enable modules. Update iOS to include armv7s.

[ghost]

Changes:

• Converted Bolts for OS X to framework product-type. OS X had it since a long time ago, so it shouldn't affect anyone.
• Added Info.plist for OS X version of Bolts. This is required on 10.10 right now.
• Added armv7s to ARCHS for iOS, so everyone can still use it.
• Enabled module support in OS X bolts. (@import Bolts; now works).
• Cleaned up build scripts for new OS X deployment via framework.
• Cleaned up .travis.yml file

Test #1:

• ./build_framework.sh inside scripts folder.
• Try using the version that is built on Xcode 5 / 6 in few applications for both iOS and OSX.

Test #2:

• ./build_framework.sh inside scripts folder.
• Try using Bolts for OS X with Xcode 6.1 Beta targeting OS X 10.10
• Codesign shouldn't fail now.

Test #3:

• Try using Bolts for OS X in an example project
• Replace #import <Bolts/*> with @import Bolts;
• It shouldn't fail.

Oh yeah and the last one - travis CI now passes.

[grantland]

LGTM

[ghost]

[iyunknona]

?

yullifurqon
Pada 9 Okt 2014 03:51, "Nikita Lutsenko" [email protected] menulis:

Changes:

• Converted Bolts for OS X to framework product-type. OS X had it
  since a long time ago, so it shouldn't affect anyone.
• Added Info.plist for OS X version of Bolts. This is required on
  10.10 right now.
• Added armv7s to ARCHS for iOS, so everyone can still use it.
• Enabled module support in OS X bolts. (@import Bolts; now works).
• Cleaned up build scripts for new OS X deployment via framework.
• Cleaned up .travis.yml file

Test #1 #1:

• ./build_framework.sh inside scripts folder.
• Try using the version that is built on Xcode 5 / 6 in few
  applications for both iOS and OSX.

Test #2 #2:

• ./build_framework.sh inside scripts folder.
• Try using Bolts for OS X with Xcode 6.1 Beta targeting OS X 10.10
• Codesign shouldn't fail now.

Test #3 #3:

• Try using Bolts for OS X in an example project
• Replace #import <Bolts/*> with @import Bolts;
• It shouldn't fail.

Oh yeah and the last one - travis CI now passes.

You can merge this Pull Request by running

git pull https://github.com/nlutsenko-fb/Bolts-iOS framework

Or view, comment on, or merge it at:

#62
Commit Summary

• Add 'armv7s' to ARCHS for Bolts-iOS.
• Converted Bolts for Mac into framework product-type. Added
  Info.plist for it.
• Enable module support for OSX Bolts.
• Update .travis.yml to use proper Configuration.

File Changes

• M .travis.yml
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-0 (6)
• M Bolts.xcodeproj/project.pbxproj
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-1
  (52)
• M Bolts.xcodeproj/xcshareddata/xcschemes/Bolts.xcscheme
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-2
  (29)
• M Bolts.xcodeproj/xcshareddata/xcschemes/MacBolts.xcscheme
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-3
  (13)
• A Bolts/Resources/Mac-Info.plist
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-4
  (26)
• M scripts/build_framework.sh
  https://github.com/BoltsFramework/Bolts-iOS/pull/62/files#diff-5 (7)

Patch Links:

• https://github.com/BoltsFramework/Bolts-iOS/pull/62.patch
• https://github.com/BoltsFramework/Bolts-iOS/pull/62.diff

—
Reply to this email directly or view it on GitHub
#62.

[facebook-github-bot]

@ghost updated the pull request.