add custom prompt to open AI translation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negoziator
reviewed
Nov 2, 2024
src/Translator/OpenAiTranslator.php
Outdated
| @@ -114,4 +122,9 @@ public function isConfigured(): bool | |||
|
|
|||
| return $openAiConfig['api_key'] && $openAiConfig['model']; | |||
| } | |||
|
|
|||
| private function CustomPrompt(): string | |||
There was a problem hiding this comment.
Method should be in camelcase customPrompt() 😄
There was a problem hiding this comment.
fixed : ) @negoziator
Bottelet
reviewed
Nov 4, 2024
config/translator.php
Outdated
| * Example: | ||
| * 'custom_prompt' => 'This application translates medical terms consistently throughout.' | ||
| */ | ||
| 'custom_prompt' => '' |
There was a problem hiding this comment.
prompt_extension perhaps? custom_prompt I would assume it replaced the entire prompt.
There was a problem hiding this comment.
yes, I think this is better
There was a problem hiding this comment.
or maybe additional_prompt?
There was a problem hiding this comment.
Definitely better could also consider prompt_context.
There was a problem hiding this comment.
I have added now, you can think about better name for this
|
Good idea overall |
|
I have fixed the naming |
|
Thanks for the PR @WatheqAlshowaiter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some times an injected user prompt will enhance the translation, like this app is financial or medial app, and so on