Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output errors of "composer create-project" command #26

Merged
merged 2 commits into from
Feb 27, 2017
Merged

Conversation

mbrodala
Copy link
Contributor

@mbrodala mbrodala commented Feb 20, 2017

Instead of swallowing all errors by running composer create-project as test command, do this normally and declare that it creates a composer.json which can be expected as a result of this command.

This has the big advantage that all kind of errors are now shown by Puppet.

Instead of swallowing all errors by running "composer create-project" as test command, do this normally and declare that it creates a composer.json which can be expected as a result of this command.

This has the big advantage that all kind of errors are now shown by Puppet.
@mbrodala
Copy link
Contributor Author

@igalic Do you think you can make a new release with this fix?

@igalic igalic merged commit 1331b47 into master Feb 27, 2017
@igalic igalic deleted the project-errors branch February 27, 2017 10:38
@igalic
Copy link
Contributor

igalic commented Feb 27, 2017

Finished in 22.32 seconds (files took 4.37 seconds to load)
665 examples, 0 failures

i think we need one more test.

@mbrodala
Copy link
Contributor Author

Not sure what you mean exactly. You mean a test which covers the error case?

@igalic
Copy link
Contributor

igalic commented Feb 27, 2017

@mbrodala nah, one more test, so we get 666 xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants