Skip to content

Commit

Permalink
Merge pull request #8 from galileo/issue-6-4-solution
Browse files Browse the repository at this point in the history
Thanks @galileo, with your changes this is what I get on macOS now:

node:6 with debug = works!
node:7 with debug = works!
node:8 with debug = not supported with node

node:6 with inspect = works!
node:7 with inspect = works!
node:8 with inspect = works!

Because of that, I'm going to keep base image at `node:6` which is still the current LTS, thanks so much.
  • Loading branch information
BretFisher authored Jun 7, 2017
2 parents 690bdd7 + 3a431c7 commit 0837804
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
"type": "node",
"request": "attach",
"protocol": "inspector",
"port": 9229
"port": 9229,
"localRoot": "${workspaceRoot}",
"remoteRoot": "/opt/app"
},
{
"name": "Attach 5858 --debug",
Expand Down
6 changes: 3 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ services:
context: .
args:
- NODE_ENV=development
# you can use standard debug config or experimental node inspect
command: node --debug=5858 ../node_modules/nodemon/bin/nodemon.js
#command: node --inspect ../node_modules/nodemon/bin/nodemon.js
# you can use legacy debug config or new inspect
#command: ../node_modules/.bin/nodemon --debug=0.0.0.0:5858
command: ../node_modules/.bin/nodemon --inspect=0.0.0.0:9229
ports:
- "80:80"
- "5858:5858"
Expand Down

0 comments on commit 0837804

Please sign in to comment.