BRITECHSRM-234 Restructure files by feature #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if renaming the component JSX files within each (PascalCase for components) subfolders to index.js would be a good idea? To clean up the imports. So "../components/AppHeader/AppHeader.jsx" becomes "../components/AppHeader". |
|
I thought you needed to include the file extension when importing jsx files? |
|
Yes that's true, it means the components would need a Perhaps leave it for now and we can reassess! |
| @@ -1,6 +1,6 @@ | |||
| import React, { Component, PropTypes } from 'react'; | |||
| import Checkbox from 'material-ui/lib/checkbox'; | |||
| import SessionStatusService from '../services/SessionStatusService'; | |||
| import SessionStatusService from '../../../services/SessionStatusService'; | |||
There was a problem hiding this comment.
Going up three levels looks a bit fragile to me?
|
As long as the structure means that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.