Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be another release on crates.io? #24

Closed
bolshoytoster opened this issue Aug 20, 2023 · 14 comments
Closed

Will there be another release on crates.io? #24

bolshoytoster opened this issue Aug 20, 2023 · 14 comments

Comments

@bolshoytoster
Copy link
Contributor

bolshoytoster commented Aug 20, 2023

The current 'stable' (0.1.6) release of this project is over 2 years old, and depends on a horrendously old version of deno_core (0.84.0), which depends on an even more old rusty_v8 (0.22.3).

This has worked perfectly fine for me, until rust changed the size of TypeIds in nightly, which causes an assertion in said version of rusty_v8 to fail, panicing.

I can solve this by using an older compiler, but making a new release would make sure others are less likely to run into this issue in the future. (It would also bring recent performance boosts from deno and rusty_v8 as well)

@bolshoytoster
Copy link
Contributor Author

I'm using the current git version of this project, and I get a compilation error for the same reason, it looks like it's fixed in this PR on the v8 repo, so the version of deno_core depended on should be updated to one after the 15th of July to apply the fix.

My solution in the mean time is to use an older nightly compiler.

@Bromeon
Copy link
Owner

Bromeon commented Aug 21, 2023

Note that there are 2 experimental releases on crates.io, the last one from April this year 🙂

A 0.2.0 release should be possible, but to clean up some APIs I'd need to invest a bit more time, which I don't have this week. It also depends on how much effort the deno_core update would be. I'll try to have a look next week.

@bolshoytoster
Copy link
Contributor Author

@Bromeon

It also depends on how much effort the deno_core update would be.

I'd be willing to try it if you don't have the time.

@Bromeon
Copy link
Owner

Bromeon commented Aug 22, 2023

If you have the time and motivation, a PR would definitely be welcome! ❤️

@bolshoytoster
Copy link
Contributor Author

bolshoytoster commented Aug 22, 2023

@Bromeon I've updated the dependency, but the tests are failing with a SIGSEGV: invalid memory reference because of a bug in deno. I've opened an issue there.

Should I still open a PR for this or wait until it's fixed?

@Bromeon
Copy link
Owner

Bromeon commented Aug 22, 2023

Thanks so much! 💪

Should I still open a PR for this or wait until it's fixed?

That's up to you, from my side there's no urgency.

@bolshoytoster
Copy link
Contributor Author

@Bromeon I did some testing and found that deno_core = "0.200" does not have this crash, so I'll open a PR with that version.

@rscarson
Copy link
Contributor

Another beta release for the changes to the API related to serialization errors would be appreciated - I can't update my downstream app till that one is available

@rscarson
Copy link
Contributor

rscarson commented Sep 9, 2023

Can I get a timeline for the release of the next RC version? I haven't been able to publish updates to my crate in months

If it will be much longer, would you mind if I temporarily published my fork of this just so I can resume work?

@bolshoytoster
Copy link
Contributor Author

@rscarson until the next release you should be able to use the git version (js-sandbox = { git = "https://github.com/Bromeon/js-sandbox" }), to avoid having to publish a fork.

@rscarson
Copy link
Contributor

rscarson commented Sep 9, 2023

You can not publish crates that have a GitHub dependency, which is why I'd need to publish a fork

@Bromeon
Copy link
Owner

Bromeon commented Sep 12, 2023

Sorry about the delays, I can publish today evening. Is current master suitable?

@rscarson
Copy link
Contributor

Yup!

@Bromeon
Copy link
Owner

Bromeon commented Sep 12, 2023

Released as 0.2.0-rc.2.

Will probably do a "proper" release at some point, if you have input regarding that, let me know. Thanks a lot for the patience 😊

@Bromeon Bromeon closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants